Allow process multiple UnreachableStatementNode on NodeScopeResolver::processNodes()

[samsonasik]

/cc @TomasVotruba if this is accepted, this should hopefully will allow us to remove UnreachableStatementNodeVisitor on rector side.

https://github.com/rectorphp/rector-src/blob/e5d221e40d2c5acc1a92b1ded501321ee690be06/src/PHPStan/NodeVisitor/UnreachableStatementNodeVisitor.php#L17

which used if found a first UnreachableStatementNode, as phpstan only process first UnreachableStatementNode

[ondrejmirtes]

I don't want to spam the user with more of these messages, one of them is enough. But I'd accept a PR that adds this information to UnreachableStatementNode as a new getter, something like getNextStatements(): array<Stmt>.

[samsonasik]

I see, I will try

[samsonasik]

@ondrejmirtes implemented 👍 , I added addNextStatement() and getNextStatements() methods

[samsonasik]

@ondrejmirtes I am not sure how unit test error is related:

There was 1 failure:

1) PHPStan\Analyser\NodeScopeResolverTest::testFile with data set "D:\a\phpstan-src\phpstan-src\tests\PHPStan\Analyser\nsrt\generic-unions.php" ('D:\a\phpstan-src\phpstan-src\...ns.php')
Failed assertions in D:\a\phpstan-src\phpstan-src\tests\PHPStan\Analyser\nsrt\generic-unions.php:

Line 120:
Expected: 3|'foo'
Actual:   mixed

could you help verify? thank you.

[samsonasik]

@ondrejmirtes it seems working ok now, Ready to merge 👍

[ondrejmirtes]

You're not actually testing getNextStatements anywhere.

Please create a new RuleTestCase inside tests/ and write an anonymous class in getRule() that would verify this information, for example by putting the next statements into reported errors.

[samsonasik]

I will try

[samsonasik]

I've added test for getNextStatements() 1083c0b

[samsonasik]

@ondrejmirtes test added, Ready to merge 👍

[samsonasik]

@ondrejmirtes mergeable?

[samsonasik]

@ondrejmirtes Rebased 👍

[ondrejmirtes]

I just pushed some test adjustments and a failing test for you.

The output for testRuleTopLevel is currently wrong. See: https://phpstan.org/r/7a2aafcd-10b3-405d-9402-90037f780059 - the top level function is not considered unreachable currently by PHPStan. But it's included in your "next statements" which is wrong.

[samsonasik]

@ondrejmirtes I've fixed handling top level function 2427d86 👍

[ondrejmirtes]

Thank you.

[samsonasik]

Thank you @ondrejmirtes I will test on rector-src 👍

[samsonasik]

linked PR on rector-src for future reference, tested the UnreachableStatementNode::getNextStatements() and it seems working ok 🎉, see

• [PHPStan ^2.1.1] Handle next unreachable statement via UnreachableStatementNode->getNextUnreachableStatements() rectorphp/rector-src#6642