-
Notifications
You must be signed in to change notification settings - Fork 506
Support named arguments after unpacking #3742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ondrejmirtes
merged 6 commits into
phpstan:2.1.x
from
herndlm:named-arguments-after-unpacking
Jan 4, 2025
Merged
Support named arguments after unpacking #3742
ondrejmirtes
merged 6 commits into
phpstan:2.1.x
from
herndlm:named-arguments-after-unpacking
Jan 4, 2025
+84
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Dec 20, 2024
herndlm
commented
Dec 20, 2024
herndlm
commented
Dec 20, 2024
herndlm
commented
Dec 20, 2024
82f88a0
to
33a7bb2
Compare
33a7bb2
to
e1a314c
Compare
ondrejmirtes
requested changes
Jan 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this it's good to merge!
476d29e
to
c333f9c
Compare
Thank you. |
@herndlm please check the build error on the 2.1.x branch |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#11418, which is apparently the most upvoted bug right now, even though quite recent hmm
Closes phpstan/phpstan#8046