Skip to content

Support named arguments after unpacking #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 4, 2025

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Dec 20, 2024

Closes phpstan/phpstan#11418, which is apparently the most upvoted bug right now, even though quite recent hmm
Closes phpstan/phpstan#8046

@herndlm herndlm changed the base branch from 2.0.x to 2.1.x December 23, 2024 20:40
@herndlm herndlm force-pushed the named-arguments-after-unpacking branch 3 times, most recently from 82f88a0 to 33a7bb2 Compare December 24, 2024 18:37
@herndlm herndlm force-pushed the named-arguments-after-unpacking branch from 33a7bb2 to e1a314c Compare January 4, 2025 13:11
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this it's good to merge!

Verified

This commit was signed with the committer’s verified signature.
herndlm Martin Herndl

Verified

This commit was signed with the committer’s verified signature.
herndlm Martin Herndl
Fix

Verified

This commit was signed with the committer’s verified signature.
herndlm Martin Herndl
@herndlm herndlm force-pushed the named-arguments-after-unpacking branch from 476d29e to c333f9c Compare January 4, 2025 14:03
@ondrejmirtes ondrejmirtes merged commit b102d98 into phpstan:2.1.x Jan 4, 2025
91 of 100 checks passed
@herndlm herndlm deleted the named-arguments-after-unpacking branch January 4, 2025 14:08
@ondrejmirtes
Copy link
Member

Thank you.

@staabm
Copy link
Contributor

staabm commented Jan 4, 2025

@herndlm please check the build error on the 2.1.x branch

@herndlm herndlm mentioned this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants