Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect CURLOPT_ACCEPT_ENCODING alias #3703

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Remove incorrect CURLOPT_ACCEPT_ENCODING alias #3703

merged 2 commits into from
Dec 2, 2024
+22 −11

Conversation

xPaw
Copy link
Contributor

@xPaw xPaw commented Dec 2, 2024 •
edited
Loading

Fixes phpstan/phpstan#12171

> CURLOPT_ACCEPT_ENCODING === CURLOPT_ENCODING
= true

ondrejmirtes
ondrejmirtes requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test wrong type calls to to verify it's checked at all.

@xPaw xPaw requested a review from ondrejmirtes December 2, 2024 20:45
@ondrejmirtes ondrejmirtes merged commit 90933b3 into phpstan:2.0.x Dec 2, 2024
424 of 426 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

1 similar comment
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect error for CURLOPT_ENCODING
2 participants
@xPaw @ondrejmirtes