Enforce safe constructor overrides with @phpstan-consistent-constructor
#3687
+111
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
consistent-constructor-visibility
branch
2 times, most recently
from
92d4494 to
d70249b
Compare
herndlm
force-pushed
the
consistent-constructor-visibility
branch
4 times, most recently
from
e8e5d0a to
06d9e9a
Compare
herndlm
force-pushed
the
consistent-constructor-visibility
branch
from
06d9e9a to
401e135
Compare
|
Thank you. |
|
Thank you! I hope I didn't cause too much noise, sorry.. Just wanted to get the ci green and then leave PRs as they are :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#12137
very much analogue to how it works for constructor parameters.
small docs changes: phpstan/phpstan#12138