Only use last for condition to filter scope #3578
Merged
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
for-filter-last-part
branch
from
e307931 to
7ce175e
Compare
herndlm
force-pushed
the
for-filter-last-part
branch
3 times, most recently
from
e7479d7 to
2273a46
Compare
|
This pull request has been marked as ready for review. |
herndlm
force-pushed
the
for-filter-last-part
branch
from
2273a46 to
142e734
Compare
herndlm
force-pushed
the
for-filter-last-part
branch
from
142e734 to
7c587ab
Compare
|
Can you explain the PHP behaviour here like I'm five? :) I don't get what's going on. |
|
I think the main thing is that (see https://www.php.net/manual/en/control-structures.for.php) all UPDATE: having said that and while that makes sense to me, I'm not a 100% sure anymore if I adapted the right places here.. |
|
Alright, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves phpstan/phpstan#11872 but does not exactly what I hope would be possible. But with the way things currently work (going through conditions and filtering the scope) this might just not be achievable or worth it. So less precise type is better than more precise type that is wrong for me tbh :)