Add Type::sliceArray()
#3514
Merged
Add Type::sliceArray()
#3514
+243
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
slice-array
branch
3 times, most recently
from
e44aaa5 to
d00a015
Compare
|
This pull request has been marked as ready for review. |
herndlm
commented
Sep 29, 2024
herndlm
force-pushed
the
slice-array
branch
from
d00a015 to
768e1c3
Compare
staabm
reviewed
Sep 30, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves type specification edge cases slightly, but there is more potential which I definitely don't want to get into here (e.g. currently
$offsetTypeand$lengthTypeare only used for constant arrays if they are of typeConstantIntegerType).The test change is correct I believe, those array slices might not be lists, see 3v4l.org/hAv10
I dislike the 2 new
instanceof selfchecks, but they are only for BC and can be removed / will not be there in 2.0