Allow asserting array offset certainty

[ruudk]

This makes it possible to do this:

/**
 * @param array{firstName: string, lastName?: string} $context
 */
public function arrayOffset(array $context) : void
{
    assertVariableCertainty(TrinaryLogic::createYes(), $context['firstName']);
    assertVariableCertainty(TrinaryLogic::createMaybe(), $context['lastName']);
    assertVariableCertainty(TrinaryLogic::createNo(), $context['email']);
}

[phpstan-bot]

You've opened the pull request against the latest branch 2.0.x. PHPStan 2.0 is not going to be released for months. If your code is relevant on 1.12.x and you want it to be released sooner, please rebase your pull request and change its target to 1.12.x.

[staabm]

nice one!

[ruudk]

@ondrejmirtes I pushed another commit to add assertions on the errors. Is this what you had in mind?

[ruudk]

@ondrejmirtes Would be great to have this part of the next release 🙏. Does this need more testing?

[ondrejmirtes]

Don't change this signature. Don't change the many yield lines. It doesn't make sense to expect failures outside of testing the actual implementation.

There's already TypeInferenceTestCaseTest. Test it there.

[ruudk]

It seems the last part of your comment was not stored...

[ondrejmirtes]

I meant to delete that :)

[ruudk]

@ondrejmirtes Done, I hope this is what you had in mind.

[ruudk]

I did it this way, because the rest in this test did not actually ran the assertions, it only waited for thrown acceptors. See line 91 above.

So if you think we should actually call the asserts, please tell me how, and I'll make the change.

Then we can assert on the full error message.

[ruudk]

@ondrejmirtes I think this one is now ready to go. The failing tests seem not related?

[ondrejmirtes]

Thank you!