Improve Vsprintf inference #3496
Merged
+40
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
vsprintf
branch
from
860a675 to
072020b
Compare
staabm
approved these changes
Sep 26, 2024
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same logic done for
sprintfcould be done forvsprintf.Instead of a foreach on every values, I just need to check the iterableValueType.
I refacto to a method
allValuesSatisfies, because I have in mind to re-use this method to check if every values are lowercase-string.cc @staabm if you wanna review, since you seemed to work multiple times on this dynamicReturnTypeExtension.