Fix sprintf() inference for constant values with format-width in pattern #3474
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
sprintf-refac
branch
from
7d1f8c9 to
70a992d
Compare
|
This pull request has been marked as ready for review. |
staabm
force-pushed
the
sprintf-refac
branch
from
067c771 to
56f8ef9
Compare
staabm
commented
Sep 25, 2024
Comment on lines
+107
to
+108
| $matches['specifier'] === 's' | ||
| && ($checkArgType->isConstantValue()->no() || $matches['width'] === '') |
There was a problem hiding this comment.
the actual fix is here. everything else is refactoring/making code easier to read
staabm
force-pushed
the
sprintf-refac
branch
from
56f8ef9 to
f635b0e
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should not infer constant strings 1:1 when sprintf expects a format-width which can add padding characters and what-not.
fixes wrong constant value inference
https://phpstan.org/r/ea3080f4-f032-4f2f-8f3b-c5c0f0062da0
https://3v4l.org/HI0pE
We could make this more precise but I fixed only what is blocking #3475