More precise MixedType::toBoolean() with subtracted type
#3471
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Sep 23, 2024
| @@ -53,4 +53,9 @@ function subtract(mixed $m, $moreThenFalsy) { | |||
| assertType('mixed', $m); | |||
| assertType('bool', (bool) $m); // could be true | |||
| } | |||
|
|
|||
| if ($m != 0 && !is_array($m) && $m != null && !is_object($m)) { // subtract more types then falsy | |||
There was a problem hiding this comment.
the test in the above if (line 52) is still not able to narrow the type, but I think its related to that we compare 2 variables.
when comparing against literals - as we do in the new test - we at least were able to trigger the bug in the previous StaticTypeFactory::falsey()->equals($this->subtractedType) logic
clxmstaab
force-pushed
the
more-then-falsy
branch
from
94040b8 to
6a901de
Compare
staabm
force-pushed
the
more-then-falsy
branch
from
3b98ac5 to
6445c8d
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I now understood why my previous test was not failling and was able to apply the suggested fix
followup to #3421