Don't prevent checking for curl_init() false returns #3409
Merged
+20
−275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 2.0.x. PHPStan 2.0 is not going to be released for months. If your code is relevant on 1.12.x and you want it to be released sooner, please rebase your pull request and change its target to 1.12.x. |
When we decide to not ignore curl memory allocation & initialization issues entirely, this leaves us with the edge case of a zero byte input or a huge URL which might return false or never. Both seem similarly unlikely, making the return type extension not quite worthwhile.
The function map would cover them
tscni
commented
Sep 6, 2024
Comment on lines
-1363
to
-1366
| - | ||
| class: PHPStan\Type\Php\CurlInitReturnTypeExtension | ||
| tags: | ||
| - phpstan.broker.dynamicFunctionReturnTypeExtension |
There was a problem hiding this comment.
When we no longer ignore curl_init() memory allocation & initialization issues, this extension becomes mostly useless.
It would really only handle the following
- If the input contains
\0it will always return false / never - If the input is really huge it will likely return false
- If the input is an invalid URL or uses the
file://scheme it might return false on PHP 7
These are all very unlikely edge-cases, thus it seemed more reasonable to move the return type definition to the function map.
In short: curl_init() will now always return (resource|false) or (CurlHandle|false).
|
This pull request has been marked as ready for review. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#11640