Narrow string on *strlen() with positive-int #3407
Merged
+52
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Sep 6, 2024
| && count($exprNode->getArgs()) === 1 | ||
| && $exprNode->name instanceof Name | ||
| && in_array(strtolower((string) $exprNode->name), ['strlen', 'mb_strlen'], true) | ||
| && $constantType instanceof ConstantIntegerType |
There was a problem hiding this comment.
instead of comparison with ConstantIntegerType we now support IntegerRangeType
staabm
commented
Sep 6, 2024
| @@ -2192,14 +2195,11 @@ public function resolveIdentical(Expr\BinaryOp\Identical $expr, Scope $scope, Ty | |||
| } | |||
| } | |||
|
|
|||
| if ($rightType->isInteger()->yes() || $rightType->isString()->yes()) { | |||
| if ($rightType->isString()->yes()) { | |||
There was a problem hiding this comment.
as we no longer do ConstantIntegerType related checks in specifyTypesForConstantBinaryExpression we can simplify this loop again to what it looked like a few weeks ago.
|
This pull request has been marked as ready for review. |
| @@ -1283,7 +1283,7 @@ public function dataCondition(): iterable | |||
| ), | |||
| ), | |||
| [ | |||
| '$foo' => 'non-empty-string', | |||
| '$foo' => "string & ~''", | |||
There was a problem hiding this comment.
Isn't this change weird ?
Shouldn't string & ~'' be considered as non-empty-string ?
There was a problem hiding this comment.
I think its the same thing, but just a difference how the type is printed
staabm
force-pushed
the
b1
branch
2 times, most recently
from
898d6c9 to
5296a87
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#11558
separated from #3373