Prevent resolving conditional types in callable param/return types #3405
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Sep 5, 2024
| @@ -411,11 +411,21 @@ public static function containsTemplateType(Type $type): bool | |||
|
|
|||
| public static function resolveLateResolvableTypes(Type $type, bool $resolveUnresolvableTypes = true): Type | |||
| { | |||
| return TypeTraverser::map($type, static function (Type $type, callable $traverse) use ($resolveUnresolvableTypes): Type { | |||
| while ($type instanceof LateResolvableType && ($resolveUnresolvableTypes || $type->isResolvable())) { | |||
| $ignoreResolveUnresolvableTypesLevel = 0; | |||
rvanvelzen
force-pushed
the
bug-11472
branch
from
e9a7208 to
c124b2e
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unresolvable conditional types should not be forcibly resolved in callable param/return types because they generally depend on calling that callable.
Fix phpstan/phpstan#11472.