Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display parent class name for anonymous classes like native php does #3362

Merged

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek marked this pull request as ready for review August 27, 2024 07:16
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is likely insufficient. See https://github.com/phpstan/phpstan-src/pull/3374/files

@mvorisek mvorisek force-pushed the impl_8740_better_anony_identifier branch 3 times, most recently from 14e2f61 to c2e7818 Compare September 4, 2024 06:03
@mvorisek mvorisek force-pushed the impl_8740_better_anony_identifier branch from 9761e18 to d54a1c1 Compare September 4, 2024 07:54
@mvorisek mvorisek force-pushed the impl_8740_better_anony_identifier branch 2 times, most recently from c28ed63 to 217d74e Compare September 19, 2024 07:22
@ondrejmirtes ondrejmirtes changed the base branch from 1.12.x to 2.0.x September 19, 2024 07:26
@mvorisek mvorisek force-pushed the impl_8740_better_anony_identifier branch from 217d74e to 7ef9b9d Compare September 19, 2024 07:28
@ondrejmirtes ondrejmirtes merged commit 8f2307e into phpstan:2.0.x Sep 19, 2024
112 of 118 checks passed
@ondrejmirtes
Copy link
Member

Merging into 2.0.x because of impact on error messages. Thank you!

@mvorisek
Copy link
Contributor Author

Sure and thank you!

@mvorisek mvorisek deleted the impl_8740_better_anony_identifier branch September 19, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dump parent class name if anonymous
3 participants