Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 runtime support #3350

Merged
merged 14 commits into from
Aug 26, 2024
Merged

PHP 8.4 runtime support #3350

merged 14 commits into from
Aug 26, 2024

Conversation

ondrejmirtes
Copy link
Member

No description provided.

@thg2k
Copy link
Contributor

thg2k commented Aug 26, 2024

What do you think of the implicitly nullable parameters deprecation in 8.4?

@ondrejmirtes
Copy link
Member Author

@thg2k I don't understand the question. Can you be more specific about what you're asking?

@ondrejmirtes ondrejmirtes force-pushed the php-84 branch 7 times, most recently from 86fa5dd to 075677a Compare August 26, 2024 13:08
@thg2k
Copy link
Contributor

thg2k commented Aug 26, 2024

@thg2k I don't understand the question. Can you be more specific about what you're asking?

I mean that those deprecation notices are a pain. I'm thinking about submitting an RFC to revert that

@ondrejmirtes
Copy link
Member Author

@thg2k It's too late for that. And it was accepted unanimously so it's unlikely to be reverted.

@thg2k
Copy link
Contributor

thg2k commented Aug 26, 2024

I know, but it's still an idiotic change, and reverting a deprecation should still be doable even in beta period, as it's not a new feature..

@ondrejmirtes
Copy link
Member Author

This is the wrong place to discuss that.

@ondrejmirtes ondrejmirtes merged commit bb4fdfc into 1.12.x Aug 26, 2024
250 of 254 checks passed
@ondrejmirtes ondrejmirtes deleted the php-84 branch August 26, 2024 21:36
@thg2k
Copy link
Contributor

thg2k commented Aug 27, 2024

This is the wrong place to discuss that.

I know, I was just asking your opinion en passant, as I value it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants