Skip to content

Improve non strict in_array #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Aug 11, 2024

@VincentLanglet VincentLanglet marked this pull request as ready for review August 11, 2024 11:55
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@VincentLanglet VincentLanglet changed the title Improve non strict in array Improve non strict in_array Aug 11, 2024
@ondrejmirtes
Copy link
Member

Fixes phpstan/phpstan#9752 too, please add a regression test.

@VincentLanglet
Copy link
Contributor Author

Fixes phpstan/phpstan#9752 too, please add a regression test.

Hi,

It fixes this comment phpstan/phpstan#9752 (comment)
with the snippet https://phpstan.org/r/4cbdb7cd-ab24-4a52-a816-b1e378cc11b4

but it doesn't fix the original issue phpstan/phpstan#9752 (comment) with the snippet https://phpstan.org/r/341e08ac-54fe-4f45-9586-703c1707060c if I understand correctly the issue bot.

So it doesn't close phpstan/phpstan#9752.
Do you still want a non-regression test for the snippet it fixes ?

@ondrejmirtes
Copy link
Member

Sorry I didn't notice it, forget what I said, we don't need a test for that :)

@ondrejmirtes ondrejmirtes merged commit 34d74e8 into phpstan:1.11.x Aug 13, 2024
452 of 462 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants