Fix Union with float should accept integer range #3318
Merged
+62
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 1.12.x. If your code is relevant on 1.11.x and you want it to be released sooner, please rebase your pull request and change its target to 1.11.x. |
VincentLanglet
force-pushed
the
integerRange
branch
from
307747c to
0a0f8b9
Compare
|
This fixes phpstan/phpstan#9659 too, please add a regression test. |
VincentLanglet
force-pushed
the
integerRange
branch
from
338aaea to
aa3101d
Compare
Done. BTW, I do you know which issue it will solve. I assume you had a CI for this ? |
|
You can see it in the issue-bot job summary https://github.com/phpstan/phpstan-src/actions/runs/10338705040 |
|
Thank you! |
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#10248