Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bleeding edge - check mixed in unary operator #3253

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Bleeding edge - check mixed in unary operator #3253

merged 1 commit into from
Jul 19, 2024
+284 −20

Conversation

schlndh
Copy link
Contributor

@schlndh schlndh commented Jul 19, 2024

schlndh
schlndh commented Jul 19, 2024
View reviewed changes
tests/PHPStan/Rules/Operators/data/invalid-unary.php
@@ -1,5 +1,5 @@
<?php

namespace InvalidUnary;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting some weird unrelated test failures (probably due to adding foo to the global namespace), so I added the namespace here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 👍

@ondrejmirtes ondrejmirtes merged commit 8a1f098 into phpstan:1.11.x Jul 19, 2024
447 of 455 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@schlndh schlndh deleted the feature-checkMixedInUnaryOperator branch July 19, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schlndh @ondrejmirtes