Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong return type for SplFileObject::fgets() #3103

Merged

Conversation

DanielSiepmann
Copy link
Contributor

@DanielSiepmann DanielSiepmann commented May 27, 2024

The method does not return false, in contrast to function fgets(). The method will throw an exception instead.

Resolves: phpstan/phpstan#11091

The method does not return false, in contrast to function fgets().
The method will throw an exception instead.

Resolves: #11091
@ondrejmirtes ondrejmirtes merged commit 884bfa5 into phpstan:1.11.x May 27, 2024
443 of 446 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@DanielSiepmann DanielSiepmann deleted the 11091-fix-wrong-return-type branch May 28, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHPStan invalid reports SplFileObject::fgets might return false
2 participants