Function containing inlineHtml has side-effects #3072
Merged
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clxmstaab
force-pushed
the
pure-inlinehtml
branch
from
33eafc4 to
3498366
Compare
clxmstaab
force-pushed
the
pure-inlinehtml
branch
from
3498366 to
88a92c5
Compare
ondrejmirtes
requested changes
May 13, 2024
src/Analyser/NodeScopeResolver.php
Outdated
| $hasYield = false; | ||
| $throwPoints = []; | ||
| $impurePoints = [ | ||
| new ImpurePoint($scope, $stmt, 'inlineHtml', 'inlineHtml', true), |
There was a problem hiding this comment.
Please test the error message when this is done inside @phpstan-pure function. It should be nicer than inlineHtml.
I'd even say that the identifier should be renamed to something like betweenPhpTags or something.
There was a problem hiding this comment.
I did not realize these strings are taken into the rule error message.
I still have to learn the new classes and their implications :)
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#10998