Fix fatal error on constant('')

[staabm]

closes phpstan/phpstan#10867

there are only 2 other callers for this very same method in the codebase, and there we already early exit on '':

e.g.

phpstan-src/src/Type/Php/DefinedConstantTypeSpecifyingExtension.php

Lines 50 to 60 in 5c3a711

	if (
	!$constantName instanceof ConstantStringType
	|| $constantName->getValue() === ''
	) {
	return new SpecifiedTypes([], []);
	}
	return $this->typeSpecifier->create(
	$this->constantHelper->createExprFromConstantName($constantName->getValue()),
	new MixedType(),
	$context,

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

I'd like to have a stub for Name constructor and all Name subclasses constructors that enforces non-empty-string.

[staabm]

using non-empty-string names everywhere would spread across the whole codebase. I fixed the places which worked without ugly catches and baselined the remaining ones

[staabm]

tested locally with regarding __construct() in all known Name classes

➜  phpstan-src git:(bug10867) ✗ cat test4.php 
<?php

$n = new \PhpParser\Node\Name('');

$r = new \PhpParser\Node\Name\Relative('');

$fq = new \PhpParser\Node\Name\FullyQualified('');
➜  phpstan-src git:(bug10867) ✗ php bin/phpstan analyze test4.php --debug
Note: Using configuration file /Users/staabm/workspace/phpstan-src/phpstan.neon.dist.
/Users/staabm/workspace/phpstan-src/test4.php
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   test4.php                                                                                                                                                   
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  3      Parameter #1 $name of class PhpParser\Node\Name constructor expects non-empty-array<string>|PhpParser\Node\Name|non-empty-string, '' given.                 
         💡 Type #1 from the union: '' is empty.                                                                                                                     
  5      Parameter #1 $name of class PhpParser\Node\Name\Relative constructor expects non-empty-array<string>|PhpParser\Node\Name|non-empty-string, '' given.        
         💡 Type #1 from the union: '' is empty.                                                                                                                     
  7      Parameter #1 $name of class PhpParser\Node\Name\FullyQualified constructor expects non-empty-array<string>|PhpParser\Node\Name|non-empty-string, '' given.  
         💡 Type #1 from the union: '' is empty.                                                                                                                     
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ 


                                                                                                                        
 [ERROR] Found 3 errors                                                                                                 
                                                                                                                        

also created a upstream PR for PHPParser: nikic/PHP-Parser#993

[ondrejmirtes]

using non-empty-string names everywhere would spread across the whole codebase.

Yes, that's the idea. I'm not looking for a quick fix but a correct fix. Please do not baseline anything. Baseline is not supposed to grow.

[staabm]

looks like this will be a breaking change and can only be merged for 2.0?
should the crash fix be separated?

[ondrejmirtes]

Please be more careful - in some places where we gain type safety thanks to the new PHPDocs, you instantly throw it away by throwing ShouldNotHappenException.

[ondrejmirtes]

This could be tackled by a better typehint in BetterReflection.

[staabm]

fix in Roave/BetterReflection#1428

[ondrejmirtes]

It'd be great if you could finish this one. Thanks.

[staabm]

I am on it right in this moment :)

sorting out dependencies atm

[staabm]

I think this one is ready to land. the last remaining error should be fixed with Roave/BetterReflection#1428

[ondrejmirtes]

Thank you!

[staabm]

we should be able to remove this stub after the next php-parser release because of nikic/PHP-Parser#993