Make array_map argument take into account unpack
#2901
Merged
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
staabm
reviewed
Feb 2, 2024
| @@ -1315,6 +1315,16 @@ public function testBug10509(): void | |||
| $this->assertSame('PHPDoc tag @return contains unresolvable type.', $errors[1]->getMessage()); | |||
| } | |||
|
|
|||
| public function testBug10527(): void | |||
There was a problem hiding this comment.
You should move this test to the rule-test which tests the rule emitting the error you are trying to fix.
AnalyserIntegrationTest is reserved for out-of-memory or fatal error issues
ryium
force-pushed
the
ryium/issue/10527
branch
from
c1ea97b to
86366cb
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes phpstan/phpstan#10527