Use const instead of properties #2815
Merged
+15
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
zonuexe
force-pushed
the
refactor/class-const
branch
from
2e4a572
to
4fadf51
Compare
staabm
reviewed
Dec 9, 2023
| @@ -91,8 +89,8 @@ private function getPreliminarilyResolvedTypeFromFunctionCall( | |||
| return TypeUtils::toBenevolentUnion($defaultReturnType); | |||
| } | |||
|
|
|||
| if ($subjectArgumentType->isNonEmptyString()->yes() && array_key_exists($functionReflection->getName(), $this->functionsReplacePosition)) { | |||
| $replaceArgumentPosition = $this->functionsReplacePosition[$functionReflection->getName()]; | |||
| if ($subjectArgumentType->isNonEmptyString()->yes() && isset(self::FUNCTIONS_REPLACE_POSITION[$functionReflection->getName()])) { | |||
There was a problem hiding this comment.
why the change from array_key_exists to isset()?
There was a problem hiding this comment.
Certainly there is no rational reason to replace array_key_exists() with isset to shave off a few bytes. Although both compile to a ZEND_ARRAY_KEY_EXISTS instruction rather than a function call, array_key_exists() has a very slight performance advantage since it avoids the cost of a null check.
zonuexe
force-pushed
the
refactor/class-const
branch
from
d095e5f
to
5ea900c
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.