Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extensions that return default types simply return null; #2782

Conversation

zonuexe
Copy link
Contributor

@zonuexe zonuexe commented Nov 26, 2023

Prevent copy-pasting by referencing existing extensions by simply replacing it with return null;.

refs #2776 (comment)

@phpstan-bot
Copy link
Collaborator

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

@zonuexe zonuexe changed the base branch from 1.11.x to 1.10.x November 26, 2023 17:34
@ondrejmirtes ondrejmirtes merged commit e0ad408 into phpstan:1.10.x Nov 26, 2023
424 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

@zonuexe zonuexe deleted the refactor/return-type-extension-returns-null branch November 26, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants