Introduce InvalidTypesInUnionRule #2763
Conversation
|
I love it, thank you very much! |
|
Nice, thx @paulbalandan ! |
|
|
||
| namespace InvalidUnionWithMixed; | ||
|
|
||
| class Foo |
There was a problem hiding this comment.
what about applying the same rules for phpdoc types?
There was a problem hiding this comment.
We'd have to give it some more thought, thanks to type normalization mixed|null is totally fine in PHPDocs, I don't want to mark that as an error.
There was a problem hiding this comment.
a special rule only for phpdocs invalid types maybe, maybe hidden behind bleeding edge? hmm
There was a problem hiding this comment.
Invalid types in PHPDocs like string&int are already reported. If you think there is some scenario that isn't covered, open a new feature requests, thanks.
There was a problem hiding this comment.
As mentioned before, we have phpstan/phpstan#6720 already, so it might be a special thing for void mostly :)
There was a problem hiding this comment.
Void in return types should be transformed into null after a call.
There was a problem hiding this comment.
would you say only for phpdoc or in general? currently thinking were the best place is to transform types 🤔
There was a problem hiding this comment.
In MutatingScope::resolveType where MethodCall/StaticCall/FuncCall are handled.
There was a problem hiding this comment.
Ok thx, I did exactly that already 😊 looked mostly good with a couple of question marks. Will open a PR when ready.
Closes phpstan/phpstan#9185