fix named arguments for few multi-variant methods

[schlndh]

There are a few cases where PHPStorm stubs have the wrong parameter names. So I'd remove the parameter rename for named params. Since named params are only available from PHP 8, we should have the correct names from php-8-stubs.

[ondrejmirtes]

Please tell me where the "named argument variants" are being read from phpstorm-stubs. I'd say that PHP functions in php-8-stubs should always be read from there.

[ondrejmirtes]

What is the significance of this change?

[schlndh]

Please tell me where the "named argument variants" are being read from phpstorm-stubs. I'd say that PHP functions in php-8-stubs should always be read from there.

It's not the "named argument variants" that are being read from phpstorm-stubs. But the arguments are renamed based on the phpstorm-stubs. It's exactly the change that you highlighted ($phpDocParameterNameMapping = []) that turns this off for named arguments.

[ondrejmirtes]

So let's say that in phpstorm-stubs there's:

/**
 * @param int $a
 * @param string $b
 */
public function foo($a, $b): void

And in reality the named arguments are named:

public function foo($c, $d): void

I'd still expect them to be typed with int and string based on the PHPDoc from phpstorm-stubs.

Is that what this PR changes? Or something else?

[schlndh]

You're right - the $phpDocParameterNameMapping is still needed inside createNativeMethodVariant to match the phpdoc types etc. Currently it makes no difference since the named variants are only used for multi-variant methods. But if they were to expand, it might have caused some bugs. I changed it accordingly.

[ondrejmirtes]

Thank you!