Allow Redis::pconnect to have 7 parameters #2695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a similar issue that was reported in phpstan/phpstan#9413 and subsequently fixed in #2442.
The
Redis::pconnect
method also accepts 7 parameters like theRedis::connect
method, currently using all 7 available parameters on thepconnect
method will show the error:As can be seen here on the redis.stub.php the signature in the PHPStan function map is missing 2 parameters:
I've updated the function map to match the method signature.