fix: remove \ from DateTimeZone in functionMap
#2693
Conversation
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
This causes issue in thecodingmachine/safe as their generator takes phpstan's fcnmap and generates function signatures. However, now it generates e.g. `function date_create_immutable(string $datetime = "now", ?\\DateTimeZone $timezone = null): \DateTimeImmutable`. Therefore, this fix is needed.
Hi, I will merge this just to make everyone's life easier, but I disagree with the premise that the fix is really needed on PHPStan's side. PHPStan doesn't need this change and uses reflection data correctly. Also other projects might benefit from combining multiple data sources as PHPStan does because
For example: PHPStan does not need to have delta files for PHP 8.3 because it already reads stuff that changed in PHP 8.3 from https://github.com/phpstan/php-8-stubs. So if |
This causes issue in thecodingmachine/safe as their generator takes phpstan's fcnmap and generates function signatures. However, now it generates e.g.
function date_create_immutable(string $datetime = "now", ?\\DateTimeZone $timezone = null): \DateTimeImmutable. Therefore, this fix is needed. (https://github.com/thecodingmachine/safe/actions/runs/6613051619/job/17960125168?pr=432#step:18:1115)