Remove unnecessary IO #2613
Merged
Remove unnecessary IO #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
lessIO
branch
2 times, most recently
from
fad620f
to
d8ae564
Compare
staabm
commented
Sep 29, 2023
...Reflection/BetterReflection/SourceLocator/ComposerJsonAndInstalledJsonSourceLocatorMaker.php
Show resolved
Hide resolved
ondrejmirtes
requested changes
Sep 29, 2023
| foreach (array_merge($classMapFiles, $filePaths) as $file) { | ||
| if (!is_file($file)) { | ||
| continue; |
There was a problem hiding this comment.
What about checking is_file for $filePaths here?
There was a problem hiding this comment.
How is this change different to what already happened to previous version of the code?
There was a problem hiding this comment.
before this PR, every path in classMapPaths was checked twice via is_dir / is_file. after the PR only once.
There was a problem hiding this comment.
See the diff screenshot - I'd rather have the is_file / is_dir calls in foreaches than the array_filter calls.
There was a problem hiding this comment.
oh I see. I read your initial comment differently.
just reworked the code to get rid of array_filter().
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-submit less controversial part of #2596
we don't need this
is_filecall (and also not the one below foris_dir), because ofabove