Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent most $parentPhpDocBlock->getClassReflection()->isBuiltin() calls #2585

Merged
merged 1 commit into from Aug 25, 2023
Merged

Prevent most $parentPhpDocBlock->getClassReflection()->isBuiltin() calls #2585

merged 1 commit into from Aug 25, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Aug 25, 2023 •
edited

micro optimizing - re-shuffle conditions, since we only need to call into the reflection class for constructors

@ondrejmirtes ondrejmirtes merged commit 869f0c7 into phpstan:1.10.x Aug 25, 2023
411 of 414 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@staabm staabm deleted the less-reflection branch August 25, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@staabm @ondrejmirtes