connection_* functions are impure #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Aug 21, 2023
bin/generate-function-metadata.php
Outdated
| @@ -60,6 +61,21 @@ public function enterNode(Node $node) | |||
| return null; | |||
| } | |||
|
|
|||
| private function isHasSideEffectsAnnotated(Attribute $attr) | |||
There was a problem hiding this comment.
according to a conversation with a contributor on JetBrains/phpstorm-stubs, the Pure attribute has different semantics based on the 1st parameter
There was a problem hiding this comment.
the regenerated function map changed a lot.. I am not 100% sure all these changes make sense - at least no tests fail
There was a problem hiding this comment.
hmm I think I over-think this thing and I should instead just have added a new entry to the functionMetadata_original.
|
This pull request has been marked as ready for review. |
|
This pull request has been marked as ready for review. |
clxmstaab
force-pushed
the
impure-conn
branch
from
18650b1
to
170ef0c
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires JetBrains/phpstorm-stubs#1560