Simplify access to class reflections in ClassPropertiesNode rules. #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mad-briller
changed the title
mad-briller
commented
Jul 8, 2023
| throw new ShouldNotHappenException(); | ||
| } | ||
| $classReflection = $scope->getClassReflection(); | ||
| $classReflection = $this->getClassReflection(); |
There was a problem hiding this comment.
the $scope param on this method is no longer used as we can access the class reflection on the node now, however removing it would be a BC break and this class is covered by @api so i just left it there
mad-briller
force-pushed
the
class-properties-node
branch
2 times, most recently
from
6007f2e
to
7845798
Compare
mad-briller
force-pushed
the
class-properties-node
branch
from
7845798
to
c9a9d9f
Compare
|
I could see a scenario where this would be a BC break (you don't know which Scope the user was passing into the method) but in practice it's very unlikely. Thank you! |
|
that's a great point i didn't consider to be honest yeah... it would be a weird way to use the node + scope together though i'll try to get to the pr feedbacks after work later, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.