Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More precise getimagesize* return type #2438

Merged
merged 3 commits into from Jun 6, 2023
Merged

More precise getimagesize* return type #2438

merged 3 commits into from Jun 6, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jun 6, 2023 •
edited

ondrejmirtes
ondrejmirtes requested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing return types does not need to happen in bleedingEdge, only the parameter types.

@ondrejmirtes ondrejmirtes merged commit 7755854 into phpstan:1.10.x Jun 6, 2023
375 of 378 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the images branch June 6, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@staabm @ondrejmirtes