Filtering default stub files on Windows #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
|
This pull request has been marked as ready for review. |
|
This change needs a test (that fails when the changes in |
maryo
force-pushed
the
patch-1
branch
3 times, most recently
from
d3d57d2
to
483609f
Compare
|
I see. Some tests added. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComposerHelper::getVendorDirFromComposerConfig($this->currentWorkingDirectory, $composerConfig)returns path separated by
/($root . '/' . trim($vendorDirectory, '/')) and$composerConfig['config']['vendor-dir']could contain both separators.On Windows,
$this->getStubFiles()returns paths separated by\. So the vendor stub files are never filtered out on Windows.getVendorDirFromComposerConfigcould already return it normalized but I was not brave enough to change it.