Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect type for NumberFormatter::parseCurrency #2309

Merged
merged 1 commit into from Mar 29, 2023

Conversation

rovansteen
Copy link
Contributor

Just like parse, format and formatCurrency the parseCurrency method can also return false in the case of failure.

https://www.php.net/manual/en/numberformatter.parsecurrency.php

@ondrejmirtes ondrejmirtes merged commit 0d2980a into phpstan:1.10.x Mar 29, 2023
276 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@rovansteen rovansteen deleted the patch-1 branch April 11, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants