-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mysqli] Add stubs for mysqli
and mysqli_result
classes
#2295
Conversation
This pull request has been marked as ready for review. |
What are the types without the stubs added? Also, isn't this platform-dependent? Isn't the precision going to be annoying for someone who knows they're using a specific DB engine? |
I'm not sure about this question. Are you asking about other missing properties that are defined for these classes?
AFAIK, these types are the same for any platform. At least, the docs are not exposing a distinction regarding this.
IIUC, these types are specific for the MySQLi extension, regardless the MySQL engine version. |
What error are you trying to fix? How the tests fail if you remove changes in stubs? |
This is the error I'm trying to fix. |
Please add a regression test for that too. |
1633443
to
a9ed75e
Compare
Done. Please, let me know if there is something else to address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The namespaces should be more unique. Something like
namespace MySqlAffectedRowsType
. - Your playground example is about ReturnTypeRule, which means the test should be added in ReturnTypeRuleTest (for methods).
6646023
to
1b5a4c4
Compare
I've changed the namespaces and added the test to Thank you in advance. |
Thank you! |
No description provided.