Check filter_input* type param type #2271
Merged
+80
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying invalid ints there fails with a fatal error since PHP 8, see https://3v4l.org/2QvBP and https://3v4l.org/EP3T8
It would also be wrong on pre PHP 8 but there's no fatal error there at least.
This is the easiest I could come up with to check this, but it feels a bit weird. Any better ideas?
See also https://www.php.net/manual/en/function.filter-input.php and https://www.php.net/manual/en/function.filter-input-array.php
The 2 failing tests seem unrelated.
Some special handling based on PHP version could also be additionally built into e.g. #2010 (which can be merged I believe ;))