Implement @phpstan-consistent-constructor
#1296
Merged
+671
−279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new tag called
@phpstan-consistent-constructor
and a rule to enforce it.I wasn't sure which level this rule should be in, so for now I added it to level 0. But I can change it to correct one.
There are not many test cases because same things are covered by
OverridingMethodRule
tests. I only tested relevant stuff for this rule. But of course I can add more test cases, if there is an edge case we need to cover.