Fix/issue 7109

[rajyan]

fixes phpstan/phpstan#7109

See phpstan/phpstan#7109 (comment) for the discussion and implementation

[rajyan]

@ondrejmirtes
I'm almost done except the error message. Do we need a node connecting visitor to change messages by coalesce/isset/empty?

[ondrejmirtes]

Thank you, this is really nice! I'll look into improving the error message myself 😊

[ondrejmirtes]

Thank you. I'll try to improve the message directly on the branch.

[ondrejmirtes]

Alright, done: 54f1544

I took advantage of IssetCheck already knowing the right context, I also tried to preserve the original behaviour as much as possible.

[rajyan]

@ondrejmirtes
Thank you. Your changes looks better!
Didn't need to check https://github.com/phpstan/phpstan-src/pull/1253/files#diff-5cc10d718dd4dbca2d13640be20698dff3831518d541839da32e32ac86ab4c50L26-L34
because null safe property fetch is always unnecessary.

[rajyan]

@ondrejmirtes

always unnecessary.

Oh, it was not.
phpstan/phpstan#7109 (comment)

null->test->call() ?? "test";

this might be an edge case of this fix.

When there is a method call, all expression before it is evalauted (and property fetch on null cause a warning)

[ondrejmirtes]

@rajyan Can you please show that on phpstan.org/try and post the expected output? Thanks :)

[rajyan]

@ondrejmirtes
Sorry, on second thought, your fix looks perfect!

[ondrejmirtes]

Alright, feel free to submit a regression test for the null-> scenario :)