Regression test

Closes phpstan/phpstan#9307

tests/PHPStan/Analyser/Bug9307CallMethodsRuleTest.php

@@ -0,0 +1,40 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Analyser;
+
+use PHPStan\Php\PhpVersion;
+use PHPStan\Rules\FunctionCallParametersCheck;
+use PHPStan\Rules\Methods\CallMethodsRule;
+use PHPStan\Rules\Methods\MethodCallCheck;
+use PHPStan\Rules\NullsafeCheck;
+use PHPStan\Rules\PhpDoc\UnresolvableTypeHelper;
+use PHPStan\Rules\Properties\PropertyReflectionFinder;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleLevelHelper;
+use PHPStan\Testing\RuleTestCase;
+use const PHP_VERSION_ID;
+
+class Bug9307CallMethodsRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		$reflectionProvider = $this->createReflectionProvider();
+		$ruleLevelHelper = new RuleLevelHelper($reflectionProvider, true, false, true, true, false, true, false);
+		return new CallMethodsRule(
+			new MethodCallCheck($reflectionProvider, $ruleLevelHelper, true, true),
+			new FunctionCallParametersCheck($ruleLevelHelper, new NullsafeCheck(), new PhpVersion(PHP_VERSION_ID), new UnresolvableTypeHelper(), new PropertyReflectionFinder(), true, true, true, true, true),
+		);
+	}
+
+	protected function shouldTreatPhpDocTypesAsCertain(): bool
+	{
+		return false;
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-9307.php'], []);
+	}
+
+}

tests/PHPStan/Analyser/Bug9307Test.php

@@ -0,0 +1,36 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Analyser;
+
+use PHPStan\Testing\TypeInferenceTestCase;
+
+class Bug9307Test extends TypeInferenceTestCase
+{
+
+	public function dataFileAsserts(): iterable
+	{
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-9307.php');
+	}
+
+	/**
+	 * @dataProvider dataFileAsserts
+	 * @param mixed ...$args
+	 */
+	public function testFileAsserts(
+		string $assertType,
+		string $file,
+		...$args,
+	): void
+	{
+		$this->assertFileAsserts($assertType, $file, ...$args);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/../../../conf/bleedingEdge.neon',
+			__DIR__ . '/bug-9307.neon',
+		];
+	}
+
+}

tests/PHPStan/Analyser/bug-9307.neon

@@ -0,0 +1,2 @@
+parameters:
+	treatPhpDocTypesAsCertain: false

tests/PHPStan/Analyser/data/bug-9307.php

@@ -0,0 +1,56 @@
+<?php declare(strict_types=1);
+
+namespace Bug9307;
+
+use function PHPStan\Testing\assertType;
+
+class Item {
+	public int $id;
+}
+
+class Aaa
+{
+	public function test(): void
+	{
+		$objects = [];
+		$itemCache = [];
+
+		foreach ($this->getIds() as $id) {
+			if (! array_key_exists($id, $itemCache)) {
+				$items = $this->getObjects();
+				$itemCache[$id] = $items;
+			} else {
+				$items = $itemCache[$id];
+			}
+
+			// It works when the following line is uncommented.
+			//$items = $this->getObjects();
+
+			foreach ($items as $item) {
+				$objects[$item->id] = $item;
+			}
+		}
+
+		assertType('array', $objects);
+
+		$this->acceptObjects($objects);
+	}
+
+	/** @return array<int> */
+	public function getIds(): array
+	{
+		return [];
+	}
+
+	/** @return array<int, Item> */
+	public function getObjects(): array
+	{
+		return [];
+	}
+
+	/** @param array<int, Item> $objects */
+	public function acceptObjects(array $objects): void
+	{
+
+	}
+}