Fix slow enum-union with lots of cases

phpstan · Mar 22, 2024 · b00bb14 · b00bb14
1 parent 0f2366b
commit b00bb14
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -1597,6 +1597,11 @@ parameters:
 			count: 4
 			path: src/Type/TypeCombinator.php
 
+		-
+			message: "#^Doing instanceof PHPStan\\\\Type\\\\Enum\\\\EnumCaseObjectType is error\\-prone and deprecated\\. Use Type\\:\\:getEnumCases\\(\\) instead\\.$#"
+			count: 1
+			path: src/Type/TypeCombinator.php
+
 		-
 			message: "#^Doing instanceof PHPStan\\\\Type\\\\FloatType is error\\-prone and deprecated\\. Use Type\\:\\:isFloat\\(\\) instead\\.$#"
 			count: 1

diff --git a/src/Type/TypeCombinator.php b/src/Type/TypeCombinator.php
@@ -16,6 +16,7 @@
 use PHPStan\Type\Constant\ConstantFloatType;
 use PHPStan\Type\Constant\ConstantIntegerType;
 use PHPStan\Type\Constant\ConstantStringType;
+use PHPStan\Type\Enum\EnumCaseObjectType;
 use PHPStan\Type\Generic\GenericClassStringType;
 use PHPStan\Type\Generic\TemplateArrayType;
 use PHPStan\Type\Generic\TemplateBenevolentUnionType;
@@ -200,8 +201,7 @@ public static function union(Type ...$types): Type
 			if ($types[$i] instanceof StringType && !$types[$i] instanceof ClassStringType) {
 				$hasGenericScalarTypes[ConstantStringType::class] = true;
 			}
-			$enumCases = $types[$i]->getEnumCases();
-			if (count($enumCases) === 1) {
+			if ($types[$i] instanceof EnumCaseObjectType) {
 				$enumCaseTypes[$types[$i]->describe(VerbosityLevel::cache())] = $types[$i];
 
 				unset($types[$i]);