Prevent unnecessary isSuperTypeOf() calls

phpstan · Jan 30, 2024 · 142dc2f · 142dc2f
1 parent e25e29e
commit 142dc2f
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/Type/Constant/ConstantArrayType.php b/src/Type/Constant/ConstantArrayType.php
@@ -405,10 +405,12 @@ public function isSuperTypeOf(Type $type): TrinaryLogic
 				return $result;
 			}
 
-			return $result->and(
-				$this->getKeyType()->isSuperTypeOf($type->getKeyType()),
-				$this->getItemType()->isSuperTypeOf($type->getItemType()),
-			);
+			$isKeySuperType = $this->getKeyType()->isSuperTypeOf($type->getKeyType());
+			if ($isKeySuperType->no()) {
+				return TrinaryLogic::createNo();
+			}
+
+			return $result->and($isKeySuperType, $this->getItemType()->isSuperTypeOf($type->getItemType()));
 		}
 
 		if ($type instanceof CompoundType) {