Add compression support for PHP Sessions #2473
Conversation
Previously, compression was available for standard data but not for session handling. This update enables the compression of PHP sessions, allowing for more efficient Redis memory usage.
|
The failed checks result from an igbinary issue on macOS, not related to this commit |
|
Thank you for your review and suggestions. Could you please check if everything is now fine or if further improvements are needed? |
There was a problem hiding this comment.
Sorry about the ZEND_STRL Windows issue, I knew it confused Windows but had forgotten it in my old age. 😄
If you update the compress/uncompress helpers to always set the out args I'll get this merged.
I'm also happy to write a test for it. The session tests are a bit involved.
redis_session.c
Outdated
| if (session_uncompress_data(redis_sock, resp, resp_len, &compressed_buf, &compressed_len)) { // Try uncompress | ||
| *val = zend_string_init(compressed_buf, compressed_len, 0); | ||
| efree(compressed_buf); // Free the buffer allocated by redis_uncompress | ||
| } else { // Return raw data | ||
| *val = zend_string_init(resp, resp_len, 0); | ||
| } |
There was a problem hiding this comment.
If you change session_compress_data to always set the out arguments and return whether you need to free the char * you can eliminate this if/else and just always use compressed_buf and then conditionally free it based on the return value from session_compress_data.
|
Thank you for the advice. It should be better now. |
bitactive
force-pushed
the
session-compression
branch
from
fa44c7a to
be8a7be
Compare
|
Merged, thanks! |
Previously, compression was available for standard data but not for session handling. This update enables the compression of PHP sessions, allowing for more efficient Redis memory usage.