Fix the strict option on applyOnClassMethods.

[tvbeek]

Type: bugfix
Issue: Resolves #1020
Breaking change: no

The CountInLoopExpression use the applyOnClassMethods, that method didn't check the strict option on the ruleset.

The ruleset set the strict on the rule if the function is available. This will prevent a BC break.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a667f9) 92.52% compared to head (c93e65d) 92.53%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1044      +/-   ##
============================================
+ Coverage     92.52%   92.53%   +0.01%     
- Complexity     1236     1239       +3     
============================================
  Files           111      111              
  Lines          3399     3404       +5     
============================================
+ Hits           3145     3150       +5     
  Misses          254      254              

Files	Coverage Δ
src/main/php/PHPMD/AbstractRule.php	84.21% <100.00%> (+0.64%)	⬆️
src/main/php/PHPMD/RuleSet.php	87.03% <100.00%> (+0.49%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kylekatarnls]

I don't remember if the PHP level allows it but maybe it could be instanceof StrictRule instead of method_exists

[tvbeek]

I don't remember if the PHP level allows it but maybe it could be instanceof StrictRule instead of method_exists

I have thought about it but then with an interface, that is something we don't use a lot. And to have it functional for every rule I thought this is the best option.

But if preferred I can do an instance of AbstractRule check.

[AJenbo]

I would prefer it but can live with both