Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docblock tag descriptions #370

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix docblock tag descriptions #370

merged 1 commit into from
May 21, 2024

Conversation

jaapio
Copy link
Member

@jaapio jaapio commented May 17, 2024

Newlines and whitespaces were not handled as before. This caused
issues for some users because our indent-reduction was broken.
The cause seems to be an upstream issue in phpstan parser which
is not resolved yet. But this work around post processing the tokens
helps us to make it work as before.

fixes #365

Newlines and whitespaces were not handled as before. This caused
issues for some users because our indent-recuction was broken.
The cause seems to be an upstream issue in phpstan parser which
is not resolved yet. But this work around post processing the tokens
helps us to make it work as before.
@jaapio jaapio force-pushed the retry-parser-docblocs branch from 9a995f2 to 8c422ab Compare May 21, 2024 05:53
@jaapio jaapio changed the title Second attempt to fix docblock descriptions Fix docblock tag descriptions May 21, 2024
@jaapio jaapio marked this pull request as ready for review May 21, 2024 05:54
@jaapio jaapio merged commit 9d07b3f into 5.x May 21, 2024
21 of 22 checks passed
@jaapio jaapio deleted the retry-parser-docblocs branch May 21, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 5.4.0 does not add our phpstan tags
1 participant