New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add errata for addition of parameter and return type declarations to PSR-7 #1296
Conversation
This patch adds section 7.2 to the metadocument, detailing the (proposed) changes to the specification to use explicit, language-level parameter and return type declarations. It documents the addition of parameter type declarations for the 1.1 release, the addition of return type declarations for 2.0, and how implementations may adopt one or both versions. It also documents and links to the (forthcoming) package releases within the primary document, detailing the changes in brief. The format follows that of the already accepted PSR-13 evolution proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. it is a documentation clarification to explain how to correctly implement the different versions of the PSR specification.
edit: just understood what you meant with "proposed". 1.1 and 2.0 of the code do not exist yet. but seems like a sound proposal to me. if we go forward with this, i will propose the same for PSR-18.
i wonder if the interfaces described in the document should match the latest version (aka have type declarations) instead of the oldest version? or is that explicitly wanted like this in the evolution process?
For the other PSRs that have been updated, we've been leaving the spec text as-is, and just documenting the change in the metadocument. So this is fine (or at least consistent) as is. |
Core Committee vote started 2023-03-13. |
can we add more changes to psr-7 1.1 and 2.0? i would love to add #1298 which brings no code changes, but would more precisely specify some behaviour. |
This patch adds section 7.2 to the PSR-7 metadocument, detailing the (proposed) changes to the specification to use explicit, language-level parameter and return type declarations. It documents the addition of parameter type declarations for the 1.1 release, the addition of return type declarations for 2.0, and how implementations may adopt one or both versions. It also documents and links to the (forthcoming) package releases within the primary document, detailing the changes in brief.
The format follows that of the already accepted PSR-13 evolution proposal.
See also: