add option copy_artifacts_on_fail #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
reviewed
Nov 23, 2022
action.yml
Outdated
| @@ -233,6 +238,7 @@ runs: | |||
| exit $rc | |||
| shell: bash | |||
| - name: Copy artifacts within image | |||
| if: ${{ always() && inputs.copy_artifacts_on_fail == 'yes' || steps.runcmd.conclusion != 'failure' }} | |||
There was a problem hiding this comment.
Could we please use success() instead of always() here? I believe always() has a special semantic regarding cancelled tasks.
There was a problem hiding this comment.
with success() it does not work, perhaps a combination of always() && !cancelled() in this way it should skip the step if the job get canceled
added 2 commits
November 23, 2022 21:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useful when running tests and want to copy the test result even if the test fail