Fix optimize with parted #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w18/fix-optimize-parted
branch
12 times, most recently
from
2e9c71a
to
716db9b
Compare
Fix a miscalculaton of end of partition parameter for parted. It shall be the last byte of the partition, not start byte + size. This made parted fail when the partition wasn't shrunk by resize2fs. Avoid calling parted if the partition isn't shrunk by resize2fs. Fix a bug where `cleanup_image.sh` script was not aborting in case of errors, thus not revealing a corruption of generated image as reported in #87. Fix a bug where cleanup_image.sh failed using images with more than 10 partitions because of a lazy glob. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w18/fix-optimize-parted
branch
from
716db9b
to
b7f16d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.