Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test with Java 23 #3381

Merged
merged 1 commit into from
Sep 26, 2024
Merged

ci: Test with Java 23 #3381

merged 1 commit into from
Sep 26, 2024

Conversation

jorsol
Copy link
Member

@jorsol jorsol commented Sep 19, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does ./gradlew styleCheck pass ?
  3. Have you added your new test classes to an existing test suite in alphabetical order?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Sorry, something went wrong.

@davecramer
Copy link
Member

looks fine to me

@jorsol
Copy link
Member Author

jorsol commented Sep 19, 2024

Seems it requires a new version of uk.org.webcompere:system-stubs-jupiter to make the tests work:
webcompere/system-stubs#88

@davecramer
Copy link
Member

so they just got rid of java 22 ?

@jorsol
Copy link
Member Author

jorsol commented Sep 25, 2024

so they just got rid of java 22 ?

No, they need to update the bytebuddy dependency and release a new version to be also compatible with Java 23, right now they use a version that does not handle the bytecode of Java 23 so the tests on Java 23 are failing.

@davecramer
Copy link
Member

Look at other tests that are failing. They are failing on java 22 and if you go https://www.oracle.com/java/technologies/downloads/ there is no java 22

@jorsol
Copy link
Member Author

jorsol commented Sep 25, 2024

Look at other tests that are failing. They are failing on java 22 and if you go https://www.oracle.com/java/technologies/downloads/ there is no java 22

Oh, I misunderstood the question, yes, Oracle gets rid of every non-LTS version after a new version comes out.

(I was thinking about the system-stubs-jupiter dependency)

@davecramer
Copy link
Member

So we have to wait until they release bytebuddy then

@jorsol jorsol force-pushed the ci-java-23 branch 2 times, most recently from e5ed126 to bb16772 Compare September 26, 2024 10:35
@davecramer
Copy link
Member

if this passes, push this one and I'll close mine as it's irrelevant now

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Jorge Solórzano <jorsol@gmail.com>
@jorsol jorsol marked this pull request as ready for review September 26, 2024 11:00
@jorsol jorsol merged commit b71e23f into pgjdbc:master Sep 26, 2024
16 of 17 checks passed
@jorsol jorsol deleted the ci-java-23 branch September 26, 2024 11:06
@davecramer
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants