Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing chrome deps after downloading binary #1584

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rishigupta1599
Copy link
Contributor

No description provided.

packages/core/src/install.js Fixed Show fixed Hide fixed
packages/core/src/install.js Fixed Show fixed Hide fixed
const type = cp.execSync("awk -F= '/^ID=/ {print $2}' /etc/os-release | tr -d '\"'").toString().trim()
if(type == 'ubuntu' || type == 'debian' || type == 'fedora') {
const directory = path.resolve(url.fileURLToPath(import.meta.url), `./dependency.sh`)
cp.execSync(`${directory} ${exec}`, { stdio: 'inherit' })

Check failure

Code scanning / Semgrep OSS

Semgrep Finding: javascript.lang.security.detect-child-process.detect-child-process Error

Detected calls to child_process from a function argument exec. This could lead to a command injection if the input is user controllable. Try to avoid calls to child_process, and if it is needed ensure user input is correctly sanitized or sandboxed.
} else if(type == 'alpine'){
const directory = path.resolve(url.fileURLToPath(import.meta.url), `../dependency_alpine.sh`)
cp.execSync(`apk add sudo bash`, { stdio: 'inherit' })
cp.execSync(`bash ${directory} ${exec}`, { stdio: 'inherit' })

Check failure

Code scanning / Semgrep OSS

Semgrep Finding: javascript.lang.security.detect-child-process.detect-child-process Error

Detected calls to child_process from a function argument exec. This could lead to a command injection if the input is user controllable. Try to avoid calls to child_process, and if it is needed ensure user input is correctly sanitized or sandboxed.
Copy link

This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the 🍞 stale Closed due to inactivity label May 14, 2024
@rishigupta1599 rishigupta1599 removed the 🍞 stale Closed due to inactivity label May 16, 2024
Copy link

github-actions bot commented Jun 4, 2024

This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the 🍞 stale Closed due to inactivity label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍞 stale Closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant